Modify install.rdf to install under SeaMonkey (diff attached)

[LewisR]

Nice work, Richard!

It would be great if you would just tweak the install.rdf to include SeaMonkey (the chrome urls for this are identical to TB). I've tested this under SeaMonkey on OS/2 and SeaMonkey on Linux, as well as making sure that I didn't break the install.rdf for TB.

From my diff:

diff -u6 -r smiley_fixer-1.3-tb/install.rdf smiley_fixer-1.3-tb+sm-mod/install.rdf
--- smiley_fixer-1.3-tb/install.rdf 2013-01-19 13:08:12.000000000 -0500
+++ smiley_fixer-1.3-tb+sm-mod/install.rdf  2013-11-26 22:33:50.000000000 -0500
@@ -15,8 +15,15 @@
       <Description>
         <em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id> <!-- Thunderbird -->
         <em:minVersion>3.0.1</em:minVersion>
         <em:maxVersion>17.*</em:maxVersion>
       </Description>
     </em:targetApplication>
+    <em:targetApplication>
+      <Description>
+        <em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id> <!-- SeaMonkey -->
+        <em:minVersion>2.0</em:minVersion>
+        <em:maxVersion>2.*</em:maxVersion>
+      </Description>
+    </em:targetApplication>
   </Description>
 </RDF>

Thanks!

Lewis

[richq]

Thanks! I've pushed it now, I'll get round to updating the mozilla site plugin at some point, but the last version has been sat in their review queue for 7 months :(

[richq]

Unfortunately this failed the automatic version check on the add-ons site. Having max 2.* doesn't do it for them. I don't know much about Seamonkey, but from the link on the warning it seems like setting max version to 2.26 should do the trick. What do you think? I've submitted it like that anyway, so I'll close this issue if/when it's approved.

Error: The maximum version that was specified is not an acceptable version number for the Mozilla product that it corresponds with.

Version "2.*" isn't compatible with "seamonkey".

[LewisR]

Ugh...

2.26 seems like we'll/you'll be updating the install.rdf too often. I would go with 2.9, Rich. I don't anticipate anything changing WRT this extension's compatibility until at least 3.0, and that is a long, long way off, AFAIK.

Thanks for letting me know. This is good information, as I've never submitted an extension to AMO.

Cheers

Lewis

[LewisR]

Scratch that. I see from the appversions page that the best we can do is 2.26, so let's go for it.

;-)

[richq]

This was fixed in commit 821235760a2b9c469e29f2286798ed3b6be38448 a while ago.