richrd / nxt-python

Automatically exported from code.google.com/p/nxt-python
GNU General Public License v3.0
1 stars 0 forks source link

Comments in examples made more readable + shebangs #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi,
I'm just an nxt beginner, so I just tried the examples.
Everything is ok, I just felt like contributing some minor formatting issues in 
the example files.

I added some «#/usr/bin/env python» and

#comment

is now

# Comment.

See the attached patch.

Original issue reported on code.google.com by christop...@gmail.com on 29 Jun 2012 at 8:00

Attachments:

GoogleCodeExporter commented 9 years ago
I'd like to keep these the way they are for now to reduce line length. Shebangs 
are in my opinion not required for example files as they are designed to be 
stolen from, not run. Again, this is just my opinion so if you'd like to start 
a discussion on the mailing list and get some other viewpoints, I'd be happy to 
reconsider. To be honest I don't have time to make the change right now due to 
an insane schedule and being located in the middle of nowhere, but if most 
people who are are in favor of it, I wouldn't have a problem as long as the 
lines are rewrapped to match what they are now. Thanks for your input and 
patch! This is a perfect change request.

Original comment by marcus@wanners.net on 30 Jun 2012 at 12:16

GoogleCodeExporter commented 9 years ago
To be honest, I don't quite like shebangs for such scripts. I just wanted 
homogeneity. Maybe there's no need for a discussion on the mailing list, since 
at first I was ashamed of such a minor request! We can also choose to remove 
them all. Arf, I'll start a discussion then, I'll take this opportunity to 
introduce myself.
Sorry for not having checked the line length. Anyway I didn't check the 
comments in examples/mindsensors/ so I'll make a new patch about this someday.

Original comment by christop...@gmail.com on 30 Jun 2012 at 6:05