richrobber2 / canvas-zoom

zoom and pan functionality
351 stars 23 forks source link

Compatibility issues with other extensions #106

Closed ghkim89 closed 6 months ago

ghkim89 commented 7 months ago

sd-webui-prompt-all-in-one (https://github.com/Physton/sd-webui-prompt-all-in-one)

When you install the extension and Canvas Zoom and use Canvas Zoom, there is a lag in Canvas Zoom. Lag occurs when you first draw the mask.

WebUI 1.8.0 ver

micka9fr commented 7 months ago

Hi, I have the same issues with js error at this line 389 :

function submit(endpoint, data, event_data) { let fn_index; let api_info; if (typeof endpoint === "number") { fn_index = endpoint; --> api_info = api.unnamed_endpoints[fn_index];

richrobber2 commented 7 months ago

alright i really need more storage space to be supporting all these webui frameworks

that said, im looking into the performance problems.

@micka9fr im gonna need more info about that. i dont even know what file that comes from. the only one that points to that code is ui.js and that code has nothing to do with the extention

@ghkim89 what are your system specs? i dont get any performance issues on my system =>[

i even tried throttling it. if possible can you get a performance log for me? using dev tools. i cant reproduce any issues in performance. the canvas naturally slowes down on new image updates. the undo functionallity is known to cause slowdowns because it updates a lot. that is caused by gradio and is not fixable without loosing funtionallity

edit: some info about performance tooling for chrome ]

richrobber2 commented 7 months ago

and @micka9fr i am not getting the bug. can you provide steps to reproduce the error?

ghkim89 commented 7 months ago

https://github.com/richrobber2/canvas-zoom/assets/113520648/94a8ba23-9cdc-4a26-a644-fb9b13380dec

I just used both extensions together. When I removed the prompt-all-in-one extension, the bug did not occur.

micka9fr commented 7 months ago

Hi thx for your answer and, sorry for my late answer.

The Stable Diffusion API don't work only at start (cannot use generate button). I must refresh my webpage to make my SD working.

It's not a python error, I have no error reported on the Stabily Matrix console. But when I look the console of my web browser (opera) I have that :

image

When I track the function in error with my PHPstorm it find the line here :

E:\Stability Matrix\Packages\Stable Diffusion WebUI\extensions\canvas-zoom\dist\templates\frontend\assets\index-7a57bd3a.js

I don't know how work JS with SD extention but I think it's a compilated JS. I find the same function here too :

E:\Stability Matrix\Packages\Stable Diffusion WebUI\venv\Lib\site-packages\gradio\templates\frontend\assets\index-7a57bd3a.js.map

I thought that it was a cache issues but... it's not, I have same issue when I clean my Opera cache.

I hope it will be usefull,

PS: maybe it's a interaction with an other extention....

My extention I use : image

richrobber2 commented 7 months ago

if you can click the little red arrow that would help seeing the actual error

micka9fr commented 7 months ago

At startup image When I click on "generate" the first time image

micka9fr commented 7 months ago

The line 389 image

richrobber2 commented 6 months ago

sorry i had a busy week. and now im sick. but can you tell me where that stylez.js is. because i dont seem to have it (or its built into gradio.

i odnt know if there is enough info. since non of that relates to my code, other than maybe the button.svelte file. but we dont really edit that button directly so it should not be comunicating through endpoints. i dont know what the error is. we have never encountered it

@micka9fr

richrobber2 commented 6 months ago

i made another branch with some more error handling. here

give that a try and tell me if anything errors. (i added checks to see if objects exist before running some event code

edit: if there is nothing from my code then it might mean that its not caused by my extention

richrobber2 commented 6 months ago

@micka9fr