search

richrobber2 / canvas-zoom

zoom and pan functionality
351 stars 23 forks source link

Fix contextual menu, removed old code, improve hotkeys, fix 1st Known bugs #4

Closed daswer123 closed 1 year ago

daswer123 commented 1 year ago

When I made it so that the picture would have an "overlap" turned off when the settings menu was on, the context menu on the whole page broke.

Fixed this error, as well as removed the old code.

UPD 19:11: 1) edited comments 2) Made a contextual me with a large index, so that it would overlap the picture 3) Made the context menu close in 200ms after you moved the mouse away from it. 3) Changed menu Settings to Change hotkeys so it would be understandable and made it so the user would not fall in modal window 4) Changed a little Open Brush Color, now when you click on the color selection panel opens, I think it is more convenient 5) Fixed bug with duplicate overlap and open brush color

UPD 20:22: 1) Fix bug when the user uploads a file we reset the zoom and the picture is always loaded correctly without the zoom. 2) Remake README.MD for EN and RU users

richrobber2 commented 1 year ago

is it ready to merge? @daswer123

richrobber2 commented 1 year ago

you are slowly taking over the project lol, that's not a bad thing though. it helps me when im drowning in my logic (coding can get confusing especially when its just thrown together with whatever works

richrobber2 commented 1 year ago

just gonna assume its good and merge

richrobber2 commented 1 year ago

good job man you are very helpful

daswer123 commented 1 year ago

I like your idea, and I want to give it life.

daswer123 commented 1 year ago

is it ready to merge? @daswer123

I have a few more developments, fixed a few bugs, tomorrow I will make another pull request