richsage / RMSPushNotificationsBundle

NOT MAINTAINED! ⛔️ Push notifications/messages for mobile devices. Supports iOS, Android (C2DM, GCM), Blackberry and Windows Mobile (toast only). A Symfony2 bundle.
MIT License
321 stars 152 forks source link

Close all APNS streams when setting PEM as string. #133

Closed shpagin closed 7 years ago

shpagin commented 8 years ago

When I have a set of notifications have to be sent to different iOS apps I need to set PEM as a string each time before sending push. In this case AppleNotification service uses the same stream because the apn url is not changing (https://github.com/richsage/RMSPushNotificationsBundle/blob/master/Service/OS/AppleNotification.php#L277 and https://github.com/richsage/RMSPushNotificationsBundle/blob/master/Service/OS/AppleNotification.php#L293). So a new pem was not used by AppleNotification after setting via setPemAsString(). Now it should.

ftrrtf commented 8 years ago

@richsage Could you check this PR plz? Thanks in advance.

shpagin commented 8 years ago

@richsage I've adjusted [] to array()

mente commented 7 years ago

@richsage would be awesome to see it in master

richsage commented 7 years ago

Thanks :-)