Connect once to APNS and send all pushmessages over that connection

[mac-cain13]

This fixes issue #13.

• Added some methods to manage the streams
• Supports switching from and to sandbox between messages (not of much use now, but it's future proof)
• Reconnects when connection is lost
• No changes in the class interface
• Major performance win. A very simple and not so scientific test when pushing 70 messages to APNS: Before: 32.9 seconds After: 1.1 seconds

[mac-cain13]

Please wait a moment before merging this commit into master, after sending a corrupt pushmessage to the server all other messages will not arrive. I have to solve this before any of these changes will be of any use.

Sorry for not detecting this before submitting the pull request!

[richsage]

Awesome - thanks for this! Speedy work :-) No problem, let me know when you're happy with it

[mac-cain13]

I fixed the biggest problems. Your messages will be resend if we detect that they didn't get through, this makes this pull request good enough for me to be useful and a win. There are some feature/edge cases that aren't supported yet:

• It's possible that when the second last pushmessage was corrupt, the last message send is correct PHP didn't discover that Apple disconnected and replied with an error. We need some kind of "cleanup" method for this that you can call when you've send the last message. If you keep sending pushmessages this problem will solve itself.
• We should support checking if the push was successfully send by providing a method that you can pass the returned messageID and will respond with true or the int of Apple's error code
• We should support the timestamp in the new binary format I implemented
• When you send more then 2,147,483,647 pushmessages with one iOSNotification object this will go wrong.

Are there issues that you feel we should solve before we can merge this into the master?

[gonzaloserrano]

is there any play to merge this soon? :-)

[richsage]

Yes - sorry, had a busy couple of weeks. I will try and review & merge this week :-)

[richsage]

OK - this all looks good to me - thanks for your work on it @mac-cain13! I'll merge now. Re. the points you mentioned above, they all sound like good improvements. Particularly the new timestamp - it would be good at some point in the future to be able to specify the expiry time on a per-message notification if required, but that can come later :-)

Thanks again!

[christian-kolb]

Could you please provide a example how to send multiple messages at once?

[mac-cain13]

Hi @christian-kolb,

This PR makes the library send all messages over the same connection. So you don't send multiple messages at once, but one by one and the library will make sure the same connection to Apple is used all the time.

Note that I've now switched to my own library Notificato, because I kept getting strange errors when sending somewhat higher volumes of messages. It's quite nasty to get it right since PHP isn't handling the connection to Apple to well in the case of disconnects/errors.

So you could also check out Notificato and the [Notificato Symfony bundle]. This will also give you the option of sending multiple messages at once.