search

richsage / RMSPushNotificationsBundle

NOT MAINTAINED! ⛔️ Push notifications/messages for mobile devices. Supports iOS, Android (C2DM, GCM), Blackberry and Windows Mobile (toast only). A Symfony2 bundle.
MIT License
321 stars 152 forks source link

Firebase Cloud Messaging support #141

Open siwymilek opened 8 years ago

richsage commented 7 years ago

Firstly, thanks for this PR! :-)

Aside from the inline comments above, could you also please add some detail or external reference about the setFCMOptions() method and what it can be used for.

And is the dry_run flag available for FCM at all? I'm not familiar with it, but as it seems to be based closely on GCM...

EmmanuelVella commented 7 years ago

@siwymilek Very interested with this PR, thank you ! Do you plan to finalize it ?

EmmanuelVella commented 7 years ago

@siwymilek Did you test it for real ? Currently, the data format is : {"data": {"message": "My message"}}

According to the FCM doc, it should be : {"notification": {"body": "My message"}}

https://firebase.google.com/docs/cloud-messaging/http-server-ref

siwymilek commented 7 years ago

@EmmanuelVella As far as I understand the notification parameter is going to show notification immediately, but the data parameter is passing payload to application and developer should handle it by himself.

EmmanuelVella commented 7 years ago

That sound right ! Thank you 👍

siwymilek commented 7 years ago

@richsage could I please you to review this PR?

andreiciceu commented 7 years ago

@siwymilek interested in your PR, do you plan to finalize it?