search

richsage / RMSPushNotificationsBundle

NOT MAINTAINED! ⛔️ Push notifications/messages for mobile devices. Supports iOS, Android (C2DM, GCM), Blackberry and Windows Mobile (toast only). A Symfony2 bundle.
MIT License
321 stars 152 forks source link

Decouple symfony #23

Closed davedevelopment closed 9 years ago

davedevelopment commented 11 years ago

A start on #22, at least this way people can use the basics without pulling down all of symfony

michaeljs1990 commented 9 years ago

This should really be merged in. It's a huge pain to have to install symfony when you don't even need it making dependency graphs a huge pain in the ass.

richsage commented 9 years ago

I'd really like to separate this out into a library and bundle ideally - that's why it hasn't been merged in yet. But if you're happy for it to be as-is without Symfony being a dependency then I'll re-look at it.

michaeljs1990 commented 9 years ago

I would be happy with it as is without symfony. We are using this like a library right now and just autoloading everything and using the classes that we need. I think it would be a good solution in the mean time to drop symfony/symfony while it's being ported into a lib.

davedevelopment commented 9 years ago

I've been using it for just over two years like this :)

Rebased if you do want to merge

richsage commented 9 years ago

OK that sounds good - thanks all :)

michaeljs1990 commented 9 years ago

Can we tag this as a 1.6 release? Also thanks a ton for merging this in.

richsage commented 9 years ago

Done - 0.1.6