search

richsage / RMSPushNotificationsBundle

NOT MAINTAINED! ⛔️ Push notifications/messages for mobile devices. Supports iOS, Android (C2DM, GCM), Blackberry and Windows Mobile (toast only). A Symfony2 bundle.
MIT License
321 stars 152 forks source link

Optimizing notification request performance #69

Closed kassisbassem closed 9 years ago

kassisbassem commented 10 years ago

In case of a large number of user, no need to check in every insert operation if the device idenfiers array has duplicates entries because it causes memory issue. Just check it only when we try to retrieve the list of identifier public function getGCMIdentifiers() { return array_unique($this->allIdentifiers); }

stof commented 9 years ago

This PR does not make sense. It does not contain the changes described in the description