search

richsage / RMSPushNotificationsBundle

NOT MAINTAINED! ⛔️ Push notifications/messages for mobile devices. Supports iOS, Android (C2DM, GCM), Blackberry and Windows Mobile (toast only). A Symfony2 bundle.
MIT License
321 stars 152 forks source link

Configure timeout #84

Closed richsage closed 9 years ago

richsage commented 9 years ago

Fixes #80. Defaults are as before - 5 seconds for Android, Blackberry and Windows (since they use the Buzz client), and 60.

ping @andrewsmm @emiliomg - could you both test and see if this helps you?

emiliomg commented 9 years ago

Thank you. I will review this PR in the evening :-)

emiliomg commented 9 years ago

The PR does not work yet, you did not set the necessary "rms_push_notifications.INSERT_PLATFORM_HERE.timeout" parameter in RMSPushNotificationsExtension.php, so the DI cannot resolve the requested parameter key.

richsage commented 9 years ago

Ah yeah, that'll teach me to try and do it quickly :-) I've added it now, could you check?

emiliomg commented 9 years ago

Thank you. Yes, I will check it out as soon as I can.

emiliomg commented 9 years ago

Works fine with android. Didn't test the rest ;-)

ghost commented 9 years ago

i raised the limit to 120 (for iOS) but it still timeouts. maybe my problem is somewhere else, but where? sometimes notifications pass, sometimes they don't :/

emiliomg commented 9 years ago

So, can this branch be merged? :)

ghost commented 9 years ago

Sure thing.