richsmith / sexytopo

The SexyTopo cave surveying app for Android
GNU General Public License v3.0
30 stars 13 forks source link

Start new survey - wierd naming of stations #125

Closed AndrewAkinson closed 5 years ago

AndrewAkinson commented 5 years ago

When starting a new survey at station 33 (although it could have been 34 as I cannot open the actual file) the new survey starts at station 3.4

Not really a problem, but I did not notice it was not using counting numbers and just left it. It would be far better to just start at 0 or 1 on a new survey.

I and my team find the #.# format very confusing and it just leads to mistakes

richsmith commented 5 years ago

I don't believe there's any code left that uses the #.# format. New surveys are started with the same name as the station they are branched from. Sure it wasn't an old survey with station 3.4? I think it makes sense to keep the same number. If you stop halfway down a passage, you want to continue with the same numbering scheme rather than start from 1.

AndrewAkinson commented 5 years ago

The survey did have some #.# on the first leg, the calibration check, which I did first. But the station I took it from was 33. So it found 1.1, 1.2 at the start, but then chose 3.4.? Anyway as i said not that important, really just recording it for completion in case it impinges on something else in the future.

Agreed it should use the same format as previous

Andrew

On Mon, 2 Sep 2019, 19:45 Rich Smith, notifications@github.com wrote:

I don't believe there's any code left that uses the #.# format. New surveys are started with the same name as the station they are branched from. Sure it wasn't an old survey with station 3.4? I think it makes sense to keep the same number. If you stop halfway down a passage, you want to continue with the same numbering scheme rather than start from 1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/richsmith/sexytopo/issues/125?email_source=notifications&email_token=ADF43XJY65S2IK2P6ZVBP4DQHVNM5A5CNFSM4IS4IHYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WMLYI#issuecomment-527222241, or mute the thread https://github.com/notifications/unsubscribe-auth/ADF43XNZMK6PAMKY7VFZXLDQHVNM5ANCNFSM4IS4IHYA .

CaverBruce commented 5 years ago

Did a quick check with v1.3.10 All seems well, the next station inherits the numbering scheme of the previous station, whether it be 1-2-3, 1.1-1.2-1.3, or 1a-2a-3a. I haven't had any troubles of this type in recent versions.

richsmith commented 5 years ago

No idea how this could have happened then. If you try again and get the same issue you can send me the file if you like and I'll have a look. Otherwise, closing for now.