search

richsmith / sexytopo

The SexyTopo cave surveying app for Android
GNU General Public License v3.0
30 stars 13 forks source link

Therion thconfig export has quotation marks around file name #127

Closed CaverBruce closed 7 months ago

CaverBruce commented 5 years ago

This is more of a comment than an issue, and it may be operating system dependent. The thconfig files created by ST contain export statements that have quotation marks around the output file name. eg export map -proj plan -layout local -o "ME-80-AngelicaTopSurface-plan.pdf" This could be considered a 'safe' approach, however it is unnecessary if the filename does not contain any spaces. I would prefer it to not have quotation marks, but I concede this is just a personal preference to avoid unnecessary characters, and that others may not agree or care.

CaverBruce commented 5 years ago

Same applies to statements in .th and .th2 files created by ST, although ST introduces spaces and so requires the quotes in this case. eg ME-80-AngelicaTopSurface plan.xvi # causes a problem without quotes For me I would prefer the spacing character '-' as used to create the thconfig export statement, ie ME-80-AngelicaTopSurface-plan.xvi

Ensuring any name prefixes or suffixes that ST applies to filenames do not contain space characters will maximise compatibility with various user conventions I think, at least those in the Therion PocketTopo Survex ecosystem. Quotes or no quotes is probably less important, as users can delete those easily. Fixing the downstream effects of rouge spaces is much more fiddly.

CaverBruce commented 4 years ago

Also ST allows creation of a survey name that contains spaces. When these are exported to Therion format, a Therion survey object is created that also contains a space. This will not compile in Therion even if the object name is enclosed in delimiters (such as quotes). It could be considered that this is a user discipline issue, and users of ST creating data to be processed Therion should not include spaces in their object names. However ST could make it easier by either not allowing spaces, or replacing the spaces in exports with dashes.

richsmith commented 7 months ago

I'm going to keep the quotation marks. Can't stop users putting spaces in filenames now it's in their hands but hopefully SexyTopo handles the spaces OK.