richsmith / sexytopo

The SexyTopo cave surveying app for Android
GNU General Public License v3.0
30 stars 13 forks source link

HI! I have made some modifications to adaptation problem of layout #157

Closed EasyVector closed 2 years ago

EasyVector commented 3 years ago

Dear Developers!

I am the creator of issue #156, and I have made some modifications to this problem. For now, this problem has been solved. And I would appreciate it if you could revise my code and give me some advice. I am very grateful for your precious time! Thank you so much.

Here is the screenshot before my modification:

copy

the screenshot after my modification:

copy
franklinbill commented 3 years ago

Hi! I meet the same problem and I think it is a good solution.

richsmith commented 2 years ago

Hi

Thanks for the PR, and sorry for taking so long to review it. I've been getting married and changing jobs.

Unfortunately your solution doesn't work for larger screens. It doesn't look quite right - the text should be aligned with the box.

I will change the "0 instruments" to the shorter "nothing", which should work better on smaller screens. This will be in the next version, so thanks for bringing it to my attention.