richsmith / sexytopo

The SexyTopo cave surveying app for Android
GNU General Public License v3.0
29 stars 13 forks source link

Translation system #186

Open romainreignier opened 1 year ago

romainreignier commented 1 year ago

Hi, thanks for this nice app. I was in a caving survey training last week-end in France and we were taught to use SexyTopo. I have seen that the English language in the UI causes some issues for some users. Have you already considered adding translations to SexyTopo? I might to try to follow this Android tutorial to try to add translation, but I am not an Android developer.

romainreignier commented 1 year ago

I have tried to simply add a strings.xml in res/values-b+fr and this seems enough:

Screenshot of SexyTopo with some text in French

https://github.com/richsmith/sexytopo/compare/master...romainreignier:sexytopo:french_translation

I am not a survey expert so I will need to find the correct translation for some terms.

richsmith commented 1 year ago

Merci, Romain!

I would be very happy to add a French translation. This is something I'd considered doing but I was waiting until someone requested it.

Good initiative creating the PR - that is useful.

Unfortunately SexyTopo development is paused until I solve the file handling issue introduced by newer versions of Android.

I will eventually accept the PR, but not until then.

I suggest not updating the other files until the file handling issues are fixed - hopefully soon.

romainreignier commented 1 year ago

Hi @richsmith I am glad you are still active on Github, I had some doubts :) I totally understand your points. Can you point me to a description of the file handling issue? I am definitely not an Android Developer but I might have a look if I could help on anything. I have used SexyTopo on Android 12 this weekend without much issue regarding the files produced.

richsmith commented 1 year ago

The problem is the changes made by Google to how file handling works. There are now much more restrictive. Any version after Android 11 is likely to have problems.

It's good news that you find you can use it with Android 12. However, you are likely to have problems if you try importing a file or copying a file from an older phone or someone else's device.

The solution is going to be to have the user choose where to save and load files from rather than have SexyTopo manage it.

romainreignier commented 1 year ago

Thanks for your answer. I have talked with some friends that were in this survey training and several of them had issues with the files saved by SexyTopo, they have lost some data. Even one on Android 7. I wish I could help them with a known working procedure or by helping you to find a solution for SexyTopo. But firstly I would need to find a way to reproduce the issue in the Android Studio emulator.

richsmith commented 1 year ago

Data losses shouldn't happen. If it does, please get them to make a bug report.

There should be an autosave at least (File -> Restore autosave). If there's an error then Tools -> System Log might give some clues as to what happened.