richsmith / sexytopo

The SexyTopo cave surveying app for Android
GNU General Public License v3.0
31 stars 14 forks source link

Correct cross-sections in Elevation mode #27

Open richsmith opened 6 years ago

richsmith commented 6 years ago

Cross-sections in extended elevations are currently handled wrong (they're the same plane as the elevation, when they should be at right-angles). This should be corrected.

Dev Notes

Cross-section creation should be delegated to PlanView and ElevationView (Template Method strategy) so the X-section creation code can be split. Context Menu creation should be delegated to child view as well and EE menu should be modified so vertical and horizontal sections are available. Sketch data X-section format needs to be modified to include X-section type. May have saving implications.

AndrewAkinson commented 6 years ago

In elevations, two planes of cross section are possible, vertical, the normal splint a passage and horizontal, use for pitches. Both should be supported, maybe with the default being horizontal. I personally don't use vertical xsections in elevation, but some people prefer to do their xsections in the elevation, as the use of space for the drawing is usually more predictable.

Andrew

On 3 Dec 2017 6:03 pm, "Rich Smith" notifications@github.com wrote:

Cross-sections in extended elevations are currently handled wrong (they're the same plane as the elevation, when they should be at right-angles). This should be corrected.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/richsmith/sexytopo/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvN3UHqEj-Lb6Vk4TFEsApTuwl8Z30iks5s8uJxgaJpZM4Qz0XD .