search

richterger / Perl-LanguageServer

Language Server for Perl
Other
224 stars 51 forks source link

Fix diagnostic notifications override on clients #185

Closed bmeneg closed 1 year ago

bmeneg commented 1 year ago

This PR fixes the diagnostic notifications getting overridden on clients due to multiple notifications for the same file with different diagnostic results and also notifications being sent twice for each file due to a erroneous nested loop.

Fixes #184

bmeneg commented 1 year ago

@richterger this PR solves a simple bug with an obvious fix, it would help many using both vscode and vim/nvim through coc-perl. Could you take a look?

richterger commented 1 year ago

Using always the uri is not an good idea, also it works most the time. I have done a different implementation in 5ddf9c66e0cfaa07e89107bece5078cd9a8e2e4c. Please check if this works for you

bmeneg commented 1 year ago

@richterger I dropped a comment in #184, please check it there.

bmeneg commented 1 year ago

This PR was superseded by commits 5ddf9c66e0cfaa07e89107bece5078cd9a8e2e4c and 27c71b9c0e24de1a37925614b5648b695ee1959c integrated directly to master.