search

richterger / Perl-LanguageServer

Language Server for Perl
Other
224 stars 53 forks source link

Perl regex warning when modifying perl.fileFilter setting #26

Closed bmartin closed 4 years ago

bmartin commented 4 years ago

When I tried customizing perl.fileFilter like so:

    "perl.fileFilter": [".pl", ".pm", ".t", ".pod"],

That results in the following warning:

Unrecognized escape \E passed through in regex; marked by <-- HERE in m/(?:\Q.pl\E|\Q.pm\E|\Q.t\E|\Q.pod\E <-- HERE )$/ at .../lib/perl5/Perl/LanguageServer/Parser.pm line 430.

This can be fixed by replacing:

        $workspace -> file_filter_regex ('(?:' . join ('|', map { "\\Q$_\\E" } @$filter ) . ')$') ;

with

        $workspace -> file_filter_regex ('(?:' . join ('|', map { quotemeta($_) } @$filter ) . ')$') ;
richterger commented 4 years ago

Thanks for the fix, it is commited in aa5d6a289cf3a233ea514e5c0d104410de0867c4