richthegeek / phpsass

A compiler for SASS/SCSS written in PHP, brought up to date (approx 3.2) from a fork of PHamlP: http://code.google.com/p/phamlp/
http://phpsass.com/
382 stars 83 forks source link

Add basic support for 'vw', 'vh', 'vmin', 'vmax' units. #135

Closed ChALkeR closed 11 years ago

ChALkeR commented 11 years ago

Add basic support for vw, vh, vmin, vmax units (CSS3 Viewport-percentage lengths).

Without this patch phpsass removes, for example, vh from height: 20vh;, resulting in an invalid height: 20; line. Now it works, and height: 10 + 10vh; also results in correct height: 20vh;.

Actually, original SASS has no 'invalid' units, all units there are supported, even non-existent ones.

See: http://www.w3.org/TR/css3-values/#viewport-relative-lengths http://caniuse.com/viewport-units

yukulele commented 11 years ago

workaround: use unquote():

#foo{
    width: unquote('50vw');
}