search

richthegeek / phpsass

A compiler for SASS/SCSS written in PHP, brought up to date (approx 3.2) from a fork of PHamlP: http://code.google.com/p/phamlp/
http://phpsass.com/
382 stars 83 forks source link

FireSass has been replaced by FireCompass Update SassCompactRenderer.php #178

Closed joejoseph00 closed 8 years ago

joejoseph00 commented 9 years ago

We need to patch this so that projects using this library as a dependency can make use of FireCompass because FireSass was replaced by FireCompass. A project that uses this as a dependency is sassy on drupal.org. Here is the related issue: https://www.drupal.org/node/2312869

joejoseph00 commented 9 years ago

looks like the pull request failed travis ci , I'll mention this to the developer of the patch and have him take a look.

joejoseph00 commented 9 years ago

SassNumber.php line 377

two tests fail on the same issue, likely an easy fix, dig a bit on php.net for the solution.

the key to finding the solution is that it works on php 5.3 , but anything higher it fails. So we have to look into this, should be fairly easy to figure out.

PHPSass_TestCase::testUnits SassNumberException: Incompatible units: 'pt' and 'in': /home/travis/build/richthegeek/phpsass/tests/units.sass::10 Source: :more-inches 1in + ((72pt * 2in) + (36pt * 1in)) / 2.54cm /home/travis/build/richthegeek/phpsass/script/literals/SassNumber.php:377

AND

PHPSass_TestCase::testMisc

SassNumberException: Incompatible units: 'px' and 'in': /home/travis/build/richthegeek/phpsass/tests/misc.scss::98 Source: margin-left: $fluidGridGutterWidth - (0.5 / $gridRowWidth * 100px \ 1%) /home/travis/build/richthegeek/phpsass/script/literals/SassNumber.php:377

again, it should be an easy fix, the code passes on php 5.3, but fails on php 5.4 , 5.5 and 5.6. Google is our friend