Travis CI fix for > php 5.3 , workaround for data found in index 1 instead of 0 on php 5.4, 5.5, 5.6, fixes tests

richthegeek / phpsass

A compiler for SASS/SCSS written in PHP, brought up to date (approx 3.2) from a fork of PHamlP: http://code.google.com/p/phamlp/

http://phpsass.com/

382 stars 83 forks source link

Travis CI fix for > php 5.3 , workaround for data found in index 1 instead of 0 on php 5.4, 5.5, 5.6, fixes tests #182

Closed joejoseph00 closed 8 years ago

joejoseph00 commented 8 years ago

PHP versions 5.4 and higher (5.5, 5.6, etc) have a newer empty() function that behaves differently than in previous versions of php such as 5.3 and older.

see notes here for explanation:

https://tournasdimitrios1.wordpress.com/2012/09/24/phps-isset-vs-empty-vs-is_null/

I'll make a pull request for this

joejoseph00 commented 8 years ago

Ok, I re-forked and fixed the commit messages, see commit https://github.com/joejoseph00/phpsass/commit/5d385f5fa6d9410b2079b0b3cdb52afe262b45a4

joejoseph00 commented 8 years ago

see pull request #184