rick147 / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Dependencies in an 'action' section are resolved with ninja but not with msvs #375

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
It looks like the problem that gyp doesn't like to have a dependency in an
'actions' section when you build with msvs, however this work fine with ninja.

Here's an example, with 2 versions of a CL:

1) https://codereview.chromium.org/23460023/diff/8001/chrome/chrome_syzygy.gypi
2) https://codereview.chromium.org/25890006/diff/22001/chrome/chrome_syzygy.gypi

In 1) , the dependency to copy_syzyasan_binaries is in the 'action' section 
(named 'Instrument Chrome with SyzyAsan'). This CL work fine when you do a 
ninja build (the target copy_syzyasan_binaries is generated). However, if you 
try to generate this with msvs then there's nothing referencing the target 
copy_syzyasan_binaries in the generated solution :(. 

CL 2) fix this, I had to move the dependency out of the 'action' section.

Even if my problem has been fixed, I'm curious to know why there's a different 
behavior depending on your GYP_GENERATOR... This is pretty bad as I (and I 
assume that I'm not the only one) tend to test my CL locally with ninja, as CL 
#1 was working fine locally I've pushed it, it reached the win-asan builder and 
we had a Canary with a missing dependency :( (the win-asan builder use msvs).

Original issue reported on code.google.com by sebmarchand@chromium.org on 17 Oct 2013 at 5:59

GoogleCodeExporter commented 9 years ago

Original comment by scottmg@chromium.org on 17 Oct 2013 at 6:01