search

rickard67 / Emmet-Pascal

Emmet components for use in Delphi or Lazarus
Other
10 stars 11 forks source link

unneeded space char before the 'class=' #4

Closed Alexey-T closed 2 years ago

Alexey-T commented 2 years ago

img, and some other tags (2-4 tags, or all other tags?) give redundant space before class="nn"

img.nn ->

<img src="" alt=""  class="nn"/>

base.nn ->

<base href=""  class="nn"/>
Alexey-T commented 2 years ago

@rickard67

NaincyKumariKnoldus commented 2 years ago

Hey @Alexey-T Can I do this please?

Alexey-T commented 2 years ago

What do you mean.

NaincyKumariKnoldus commented 2 years ago

Hey @Alexey-T I mean can I remove this space and raise a PR for this.

Alexey-T commented 2 years ago

Please do it :)

Alexey-T commented 2 years ago

I am not sure @rickard67 reads here. We need to ping him at the RJ-TextEd forum

NaincyKumariKnoldus commented 2 years ago

Hey @rickard67

rickard67 commented 2 years ago

Thanks. I'll look into it when I get the time.

I would appreciate it if you want to create a pull request. I'll check it when I can and merge it with the repository.

NaincyKumariKnoldus commented 2 years ago

Hey @rickard67 I found class in demo.dproj file. I have to correct it there?

rickard67 commented 2 years ago

The problem can be found in the .\emmet\emmet.pas file. It seems the code adds an extra space between "alt" and "class" instead of "class="nn"" and "/>".

rickard67 commented 2 years ago

It's been fixed in the upcoming update.