search

rickardgranberg / terraform-provider-vaultoperator

Terraform Provider for Vault Operator operations
Mozilla Public License 2.0
19 stars 11 forks source link

FEAT: adding option to ignore ssl errors #13

Closed venkatamutyala closed 1 year ago

venkatamutyala commented 1 year ago

Hi, I'm aware of workarounds but would you entertain taking a PR that makes ignoring SSL errors a toggle? I am thinking of a similar implementation to how the vault provider from hashicorp does it (skip_tls_verify

I feel like it would make the provider cleaner and less effort to use if we had this feature.

References

Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

venkatamutyala commented 1 year ago

@rickardgranberg any thoughts? If you didn't have time to make the change yourself I was thinking of taking the time this coming weekend to work on it and send you a PR. But before I write code, wanted to see if the proposal is something you would accept.

rickardgranberg commented 1 year ago

@rickardgranberg any thoughts? If you didn't have time to make the change yourself I was thinking of taking the time this coming weekend to work on it and send you a PR. But before I write code, wanted to see if the proposal is something you would accept.

I'd gladly accept a PR, please go ahead!

venkatamutyala commented 1 year ago

@rickardgranberg Please feel free to close this out. I won't be working on it. I found I can just run export VAULT_SKIP_VERIFY=true and it ends up being a clean solution for my needs.

venkatamutyala commented 1 year ago

Added a note to the docs here: https://github.com/rickardgranberg/terraform-provider-vaultoperator/pull/17