search

rickbansal-mulesoft / otel-mule4-observability-agent

12 stars 6 forks source link

You may be stepping on some headers #4

Open jbsouthe opened 2 years ago

jbsouthe commented 2 years ago

Rick, was reading through your header processor, and you may be having issues because you are creating new headers but not adding the existing headers to the list. this part of the code may not be working because you are not making sure to keep the current request intact. Thank you for sharing this and demoing it today.

https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/blob/5f13d0b648fca99fb357d0e7f1b423518f9bb790/src/main/java/org/mule/extension/otel/mule4/observablity/agent/internal/interceptor/TracingProcessorInterceptor.java#L66

rickbansal-mulesoft commented 2 years ago

Hey John,

Thanks for joining and chiming in. Really appreciate the input. Unfortunately, it's not possible for me to modify the request headers (they are immutable) even in the inspector. I commented out the code to avoid confusion. This something the Runtime will have access to and be able to handle. Have a great long weekend!

Thanks, Rick

On Thu, May 26, 2022 at 1:19 PM John Southerland @.***> wrote:

Rick, was reading through your header processor, and you may be having issues because you are creating new headers but not adding the existing headers to the list. this part of the code may not be working because you are not making sure to keep the current request intact. Thank you for sharing this and demoing it today.

https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/blob/5f13d0b648fca99fb357d0e7f1b423518f9bb790/src/main/java/org/mule/extension/otel/mule4/observablity/agent/internal/interceptor/TracingProcessorInterceptor.java#L66

— Reply to this email directly, view it on GitHub https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKKJIYT6VJZRQZ5I4ZCUOTVL66DVANCNFSM5XB6MQCA . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

-- http://www.mulesoft.com/ Rick Bansal, Strategic Enterprise Architect

Dallas, TX

M 214.476.798 <214.476.7098> @.***

https://www.linkedin.com/company/mulesoft https://twitter.com/mulesoft https://www.facebook.com/MuleSoft https://videos.mulesoft.com/ We're hiring! http://www.mulesoft.com/careers

jbsouthe commented 2 years ago

Rick, Thanks for having me.

I understand that, but in instances like this, you can read them and add them to the new headers you are building. I’ve had to rebuild entire requests to add one small thing. It may help if you try that. Thanks, John

On May 26, 2022, at 12:57 PM, rickbansal-mulesoft @.***> wrote:

Hey John,

Thanks for joining and chiming in. Really appreciate the input. Unfortunately, it's not possible for me to modify the request headers (they are immutable) even in the inspector. I commented out the code to avoid confusion. This something the Runtime will have access to and be able to handle. Have a great long weekend!

Thanks, Rick

On Thu, May 26, 2022 at 1:19 PM John Southerland @.***> wrote:

Rick, was reading through your header processor, and you may be having issues because you are creating new headers but not adding the existing headers to the list. this part of the code may not be working because you are not making sure to keep the current request intact. Thank you for sharing this and demoing it today.

https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/blob/5f13d0b648fca99fb357d0e7f1b423518f9bb790/src/main/java/org/mule/extension/otel/mule4/observablity/agent/internal/interceptor/TracingProcessorInterceptor.java#L66

— Reply to this email directly, view it on GitHub https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKKJIYT6VJZRQZ5I4ZCUOTVL66DVANCNFSM5XB6MQCA . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

-- http://www.mulesoft.com/ Rick Bansal, Strategic Enterprise Architect

Dallas, TX

M 214.476.798 <214.476.7098> @.***

https://www.linkedin.com/company/mulesoft https://twitter.com/mulesoft https://www.facebook.com/MuleSoft https://videos.mulesoft.com/ We're hiring! http://www.mulesoft.com/careers — Reply to this email directly, view it on GitHub https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/issues/4#issuecomment-1138907955, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXAFUTJ7QUTX6NDRQP4CUTVL7CQPANCNFSM5XB6MQCA. You are receiving this because you authored the thread.

rickbansal-mulesoft commented 2 years ago

Thanks John. Will give it a try.

On Thu, May 26, 2022 at 1:59 PM John Southerland @.***> wrote:

Rick, Thanks for having me.

I understand that, but in instances like this, you can read them and add them to the new headers you are building. I’ve had to rebuild entire requests to add one small thing. It may help if you try that. Thanks, John

On May 26, 2022, at 12:57 PM, rickbansal-mulesoft @.***> wrote:

Hey John,

Thanks for joining and chiming in. Really appreciate the input. Unfortunately, it's not possible for me to modify the request headers (they are immutable) even in the inspector. I commented out the code to avoid confusion. This something the Runtime will have access to and be able to handle. Have a great long weekend!

Thanks, Rick

On Thu, May 26, 2022 at 1:19 PM John Southerland @.***> wrote:

Rick, was reading through your header processor, and you may be having issues because you are creating new headers but not adding the existing headers to the list. this part of the code may not be working because you are not making sure to keep the current request intact. Thank you for sharing this and demoing it today.

https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/blob/5f13d0b648fca99fb357d0e7f1b423518f9bb790/src/main/java/org/mule/extension/otel/mule4/observablity/agent/internal/interceptor/TracingProcessorInterceptor.java#L66

— Reply to this email directly, view it on GitHub < https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/issues/4 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AKKKJIYT6VJZRQZ5I4ZCUOTVL66DVANCNFSM5XB6MQCA

. You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

-- http://www.mulesoft.com/ Rick Bansal, Strategic Enterprise Architect

Dallas, TX

M 214.476.798 <214.476.7098> @.***

https://www.linkedin.com/company/mulesoft < https://twitter.com/mulesoft> https://www.facebook.com/MuleSoft https://videos.mulesoft.com/ We're hiring! http://www.mulesoft.com/careers — Reply to this email directly, view it on GitHub < https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/issues/4#issuecomment-1138907955>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXAFUTJ7QUTX6NDRQP4CUTVL7CQPANCNFSM5XB6MQCA . You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub https://github.com/rickbansal-mulesoft/otel-mule4-observability-agent/issues/4#issuecomment-1138910285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKKJIZTU76FCD5VMWQ7P3DVL7C2JANCNFSM5XB6MQCA . You are receiving this because you commented.Message ID: <rickbansal-mulesoft/otel-mule4-observability-agent/issues/4/1138910285@ github.com>

-- http://www.mulesoft.com/ Rick Bansal, Strategic Enterprise Architect

Dallas, TX

M 214.476.798 <214.476.7098> @.***

https://www.linkedin.com/company/mulesoft https://twitter.com/mulesoft https://www.facebook.com/MuleSoft https://videos.mulesoft.com/ We're hiring! http://www.mulesoft.com/careers