search

rickbutterfield / Umbraco.Community.BlockPreview

Easy to use rich HTML backoffice previews for the Umbraco Block List and Block Grid editors.
MIT License
20 stars 12 forks source link

Edit Blocks in Areas opens both Blocks #1

Closed nielslyngsoe closed 1 year ago

nielslyngsoe commented 1 year ago

Hi @rickbutterfield, first I want to highlight fantastic work!

I want to let you know that I experience an issue, which should be relatively easy to fix.

When I click a Block that is placed within a Block Area, when it opens both the clicked Block and the parent Blocks. This is caused by the click event propagating, I think the immediate fix would be to add a ng-click="$event.stopPropagation()" on your Area slots.

As well it would be nice to support the Single Area Rendering: @await Html.GetBlockGridItemAreaHtmlAsync(Model, "myAreaAlias")

It was introduced relatively late and I'm not sure if we have it documented, sorry for that.

It is used for the inspiration block Partial View in the example website project: https://github.com/umbraco/Umbraco.BlockGrid.Example.Website

Again thanks for the well-made package, leading the way for how this is done!

rickbutterfield commented 1 year ago

Thank you @nielslyngsoe! You've raised two very good points. I found that I was having the JS overlay issue as well but wasn't sure how to fix it, in my initial testing your fix works 🎉

I think I've got single area rendering working, tested it against the BlockGridExample website Inspiration block like you mentioned, hopefully it's generic enough to work with any block.