rickbutterfield / Umbraco.Community.BlockPreview

Easy to use rich HTML backoffice previews for the Umbraco Block List and Block Grid editors.
MIT License
15 stars 10 forks source link

Previews not working after updating to 1.8.3 #51

Closed OwainJ closed 4 months ago

OwainJ commented 5 months ago

Which Umbraco.Community.BlockPreview version are you using?

1.8.3

Which Umbraco version are you using? For example: 10.4.0 - don't just write v10

13.2.2

Bug summary

After updating from 1.8.2 to 1.8.3, the block list previews have stopped working. image

Downgrading back to 1.8.2 fixes the issue, and the previews render as expected.

There are no errors in the browser console, or the Umbraco log, but I can see that the preview markup API response is empty: image

Whereas on 1.8.2, the response looks like this: image

Steps to reproduce

I haven't tried reproducing this on a fresh install yet, will update when I do.

Expected result / actual result

Previews should render.

bielu commented 5 months ago

@OwainJ I think it might be same issue / or related, as this one: https://github.com/rickbutterfield/Umbraco.Community.BlockPreview/issues/50 can you try to move them to blockgrid folder just to see if is the same?

OwainJ commented 5 months ago

Hi @bielu, yup, can confirm that moving my /Components folder from /blocklist to /blockgrid got the rendering working:

1 2
image image

Note: my block list is not nested like in #50, it's just a property on a DocType

bielu commented 5 months ago

interesting!

AlexanderWagner82 commented 4 months ago

I'm having the same problem with Umbraco.Cms 13.3.0, Umbraco.Community.BlockPreview both with 1.8.2 and 1.8.3.

Works perfectly with Umbraco.Cms 13.2.2 and BlockPreview 1.8.2

rickbutterfield commented 4 months ago

Hi @OwainJ, @AlexanderWagner82

There's a fix for this (of course it one only a one liner!!) that's being released as v1.8.4 right now. Please give it a try once released to NuGet and let me know how you get on.

OwainJ commented 4 months ago

Happy to confirm that it works perfectly for me now on v1.8.4! Cheers Rick!

AlexanderWagner82 commented 4 months ago

Works like a charm on Umbraco.Cms 13.3.0. Thank you very much!