search

rickclephas / NSExceptionKt

A Kotlin Multiplatform Library to improve crash reports on Apple platforms
MIT License
181 stars 12 forks source link

Remove sentrycrash_async_backtrace_decref #16

Closed hbmartin closed 1 year ago

hbmartin commented 1 year ago

Addresses https://github.com/rickclephas/NSExceptionKt/issues/15

hbmartin commented 1 year ago

@rickclephas this is still crashing on terminateWithUnhandledException at https://github.com/rickclephas/NSExceptionKt/blob/222bd7a5e0a8e8c1b6bb133257246ea1a83581dc/nsexception-kt-core/src/commonMain/kotlin/com/rickclephas/kmp/nsexceptionkt/core/UnhandledExceptionHook.kt#L20 - even though the error in my project is happening inside of a try / catch block. edit: derp, catching wrong class :facepalm: What's the expected behavior here? Wouldn't we not want to terminate?

rickclephas commented 1 year ago

Hmm that is strange, only unhandled exceptions should be received by that hook, in which case the final termination is expected/required.

rickclephas commented 1 year ago

Tested with Sentry 7.21.0 and 8.10.0