search

ricketytoc / pe

0 stars 0 forks source link

Missing parameters for execute function for all sequence diagrams #4

Open ricketytoc opened 11 months ago

ricketytoc commented 11 months ago

Screenshot 2023-11-17 at 5.22.23 PM.png Screenshot 2023-11-17 at 5.22.23 PM

Screenshot 2023-11-17 at 5.21.59 PM.pngScreenshot 2023-11-17 at 5.21.59 PM

Description

The execute method is missing the Model parameter for all sequence diagrams.

Justification

Since there are more than 5 of such instances I think that this is a medium severity bug.

nus-pe-bot commented 11 months ago

Team's Response

This issue is not in the scope of the DG because if we include all the unnecessary parameters in all method calls, it would decrease readability which was why we chose to only include the most important parameters (input that comes from users and parsed accordingly in our system) that directly affects Model.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]