rickgaiser / neutrino

Small, Fast and Modular PS2 Device Emulator
Academic Free License v3.0
61 stars 3 forks source link

ESR patched disk compatibility #12

Open rickgaiser opened 10 months ago

rickgaiser commented 10 months ago

ESR is now supported, but the compatibility is not as good as ESR, this needs to be fixed.

This is probably caused by the rewritten IOP modules, embedded into this project:

This is the ingame module: https://github.com/rickgaiser/neutrino/tree/master/iop/esr_cdvdv Not much has changed, compared to the original: https://gitlab.com/ffgriever/esr/-/tree/master/cdvdv_sce?ref_type=heads

This is the new combined bios+patch module: https://github.com/rickgaiser/neutrino/tree/master/iop/esr_pcdvdv Its based on the merger of the following modules: https://gitlab.com/ffgriever/esr/-/tree/master/cdvdv_bios?ref_type=heads https://gitlab.com/ffgriever/esr/-/tree/master/pcdvdv_sce?ref_type=heads

I think the detection of bios version is incorrect / causing issues: https://github.com/rickgaiser/neutrino/blob/fa5bfa1e1b05526c563df272344fbc25aed1b581/iop/esr_pcdvdv/src/pscecdvdv.c#L125-L130 https://github.com/rickgaiser/neutrino/blob/fa5bfa1e1b05526c563df272344fbc25aed1b581/iop/esr_pcdvdv/src/pscecdvdv.c#L140-L144

I'll leave this issue open for anyone interested to look into it and try to fix the issue.