search

rickgaiser / neutrino

Small, Fast and Modular PS2 Device Emulator
Academic Free License v3.0
61 stars 3 forks source link

[ee core] make cheat engine a togleable feature #27

Open israpps opened 3 weeks ago

israpps commented 3 weeks ago

to save a bit of EE RAM when not needed?

rickgaiser commented 1 week ago

It's a shame we can't use a modular approach like we do on the IOP for the EE also. But adding a compile time #ifdef like this will result in 2x the number of ee_core.elf files, and that number can grow very fast. For instance 4 feature ifdef's result in 2^4=16 different versions.

I would prefer to keep it a single (full featured) ee_core. If the ee_core becomes too big we can put code into specific sections using the linkfile. Like for instance:

israpps commented 1 week ago

It's a shame we can't use a modular approach like we do on the IOP for the EE also. But adding a compile time #ifdef like this will result in 2x the number of ee_core.elf files, and that number can grow very fast. For instance 4 feature ifdef's result in 2^4=16 different versions.

I would prefer to keep it a single (full featured) ee_core. If the ee_core becomes too big we can put code into specific sections using the linkfile. Like for instance:

  • essential code -> 0x00084000
  • non-essential (feature) code -> 0x000D0000 If a game overwrites non used feature code, then everything will still work as expected.

My intention was never to make this a variant compiled all the time.

The idea is just to make it togleable. if someone wants EE Core without cheat engine, then only recompiling will be needed, no code touching. thats why this PR didnt touch a single byte of the CI file

israpps commented 3 days ago

@rickgaiser

rickgaiser commented 3 days ago

If you want/need this for your development then I can merge it. But I personally don't see a need, only 20 added lines of (for me) useless code.

israpps commented 3 days ago

If you want/need this for your development then I can merge it. But I personally don't see a need, only 20 added lines of (for me) useless code.

yeah, buf it you wanna strip it away, you just set a make variable instead of touching code.

rickgaiser commented 3 days ago

If you fix the merge conflict I'll merge the change.