search

rickgaiser / neutrino

Small, Fast and Modular PS2 Device Emulator
Academic Free License v3.0
99 stars 5 forks source link

Buffer overflow in toml_string_in_overwrite #42

Closed AKuHAK closed 20 hours ago

AKuHAK commented 1 month ago

When using various toml files (like system and later user-defined) the data may become corrupted: example in system toml default_bsdfs=hdl in user toml default_bsdfs=exfat

then it will result in sys.sBSDFS: exD Screenshot 2024-10-17 at 21 14 36

rickgaiser commented 1 month ago

I've never seen this before. I will test this when I get the chance.

rickgaiser commented 3 weeks ago

I was not able to reproduce, but also not happy with the current TOML string handling. I changes them all to properly malloc/free a new buffer for each string used.

Can you try again and see if it's fixed?