search

rickhelmus / patRoon

Workflow solutions for mass-spectrometry based non-target analysis.
https://rickhelmus.github.io/patRoon/
GNU General Public License v3.0
61 stars 18 forks source link

[JOSS Review] Make file extension for supported MS file types case insensitive #34

Closed hechth closed 2 years ago

hechth commented 2 years ago

generateAnalysisInfo finds mzML files but no mzml files, which can be impractical if working with large read-only file storage.

Seems like it starts to collect everything at first and then filterMSFileDirs actually filters case sensitive for the extensions again, so they are removed.

https://github.com/rickhelmus/patRoon/blob/b0bffbabe5605579ba8781b24336e95895c7e15c/R/convert.R#L86-L95

rickhelmus commented 2 years ago

Thanks for the suggestion and little investigation :-) Should be fixed now!