use single port instead of two

ricklamers / gridstudio

Grid studio is a web-based application for data science with full integration of open source data science frameworks and languages.

GNU Affero General Public License v3.0

8.88k stars 1.5k forks source link

use single port instead of two #103

Closed allenfoxtc closed 3 years ago

allenfoxtc commented 4 years ago

this pr include:

use single 8080 port
replace hard coding port num in js files (by using window.location.host)

it's work fine on my synology nas docker server!

i'm just a golang beginner. if any thing goes wrong, please let me know. thanks :)

belongwqz commented 4 years ago

Yeah, it should be like this.

ricklamers commented 4 years ago

I want to do some checking whether this propagates well in all areas of Grid. Seems like a reasonable change. I had it slated, to find out whether I could run it all over a single port.

ricklamers commented 3 years ago

@allenfoxtc thank you very much for this contribution! It should have been like this form the start.

(Merged now as I finally got around to testing it)