Fix #22 : Raise an exception when there are duplicates in links

ricklupton / ipysankeywidget

IPython / Jupyter Sankey diagram widget

MIT License

174 stars 24 forks source link

Fix #22 : Raise an exception when there are duplicates in links #23

Closed sildar closed 6 years ago

sildar commented 6 years ago

I checked for the following keywords:

source
target
type
color

I don't think there are others that should be checked.

I checked that the examples in the repo still worrked after this commit.

(Fixes #22)

ricklupton commented 6 years ago

Thanks! I think your first commit was right -- it should be just source, target and type that are checked because they define the graph structure. In other words, if there are two links with the same source, target and type but different colours that is still a problem. Can you drop the second commit?

sildar commented 6 years ago

This should do it. Tell me if you want me to change anything. Retested the examples, everything seemed to work fine.

ricklupton commented 6 years ago

Looks good! Thanks for your help :tada: