search

ricklupton / ipysankeywidget

IPython / Jupyter Sankey diagram widget
MIT License
174 stars 24 forks source link

Illformed order fails silently #63

Open sildar opened 3 years ago

sildar commented 3 years ago

Hi,

While creating a minimal example for another issue, I stumbled upon a silent error when the order parameter is illformed. Here is an example, where the second line of the order parameter should be ["1"] instead of "1".

links = [{"source": "A", "target": "1", "value": 5, "type": "A"},
         {"source": "B", "target": "1", "value": 10, "type": "B"},
         {"source": "C", "target": "1", "value": 15, "type": "C"},
         {"source": "1", "target": "2", "value": 10, "type": "B"},
         {"source": "1", "target": "2", "value": 5, "type": "A"},
         {"source": "1", "target": "2", "value": 15, "type": "C"}]

order = [
         ["B", "A", "C"],
         "1",
         ["2"]
]

w = SankeyWidget(links=links, order=order)
w

This is valid Python, but the widget fails silently, the diagram is not shown and there is no error message.

I may have some time next week to investigate if this could be fixed if you think it's worth the effort.

ricklupton commented 1 year ago

Sorry for the slow reply! @sildar fixes welcome if you are still interested.