Fix HMD no-light numColors and other packet issues - Githubissues

rickomax / psxprev

PSXPREV - Playstation (PSX) Files Previewer/Extractor

BSD 2-Clause "Simplified" License

193 stars 10 forks source link

Fix HMD no-light numColors and other packet issues #82

Closed trigger-segfault closed 12 months ago

trigger-segfault commented 12 months ago

Actual changes

Fixed numColors for HMD not being numVerts when !light && gouraud. In this case, the gradation bit is ignored. This fixes parsing for some models.
Added support for Unlit render flag in PMDParser, because before I didn't realise Unlit == No light source calculation.
Made animation state variables in ModelEntity unbrowsable.
Fixed standard: argument name in Scene appearing before an un-named argument. This was breaking compiling.

Refactor changes

Changed lmdBit when parsing HMD packet to being inverted to match that false == no normals.
Added other unused bits when parsing HMD packet.
Changed PrimitiveType to be assigned with a switch statement for the code, because casting from code wouldn't work for both TMD and HMD.
Removed PrimitiveType Polygon and replaced it with Triangle and Quad. Also added StripMesh and None.
HMDParser now uses primitiveType switch statement like TMDParser.