Some minor things with latest Usurper

rickparrish / Usurper

32 and 64bit ports of Usurper BBS door game version 0.20e

78 stars 18 forks source link

Some minor things with latest Usurper #14

Closed stack-fault closed 3 years ago

stack-fault commented 4 years ago

Many places in the game, the string are being sent with an extra CR, breaking the display of many ANSIs and such. But it's not everywhere. I thought it might be some files having DOS CR/LF but it comes from the binary apparently.
You can't just hit enter on several prompts where it should be allowed, two occurrences below as an example: o Attacking the first enemy in the dungeons o Abort selling all your items

I am using the latest Linux binary.

rickparrish commented 4 years ago

What BBS software are you using, and have you tried with the -X command-line parameter? It's been a long time since I worked on Usurper, but another Issue mentioned that parameter being added for STDIO mode to help with the extra CR issue.

And can you take a screenshot of any screens where hitting ENTER should work but doesn't? Having not worked on it in so long I don't recall where to find stuff, so a screenshot showing some text I can grep for should help.

codefenix-ConChaos commented 4 years ago

Here's a spot where pressing [Enter] should pick the first monster when "Fighting to Death", but it does nothing. Instead it makes you select the number.

rickparrish commented 4 years ago

Had a quick look, and I think it's related to me switching from DDPlus to my own doorkit -- there's a lot of TODO comments in there indicating I mapped the DDPlus call to what I thought the closest match was in my doorkit, but no testing was done to confirm exact matching behaviour.

And I know for sure my line input function wasn't exact matching behaviour, because it doesn't accept empty input, so that explains why hitting enter for the first monster isn't working.

I'll try switching back to DDPlus in the near future to confirm. I don't recall why I switched in the first place though...it may have fixed some issues but introduced ones like this, so then going back to DDPlus would fix these issues but reintroduce old issues.

rickparrish commented 4 years ago

Switched back to DDPlus on this branch: https://github.com/rickparrish/Usurper/tree/DDPlus

New Win32 binaries are included, but I don't have a VM setup to build for Linux so those will have to be built from source.

codefenix-ConChaos commented 4 years ago

~~> New Win32 binaries are included, but I don't have a VM setup to build for Linux so those will have to be built from source.~~

I'm finally going to test over the upcoming weekend.

~~Two questions:~~

There are two sets of Windows binaries: .exe and 32.exe. I assume they're both Win32, but only the USURPER.exe seems to have been compiled recently. What is the difference, and which should be used?

2. When compiling the DDPlus branch, Lazarus gives the error: "DDFOSSIL.PAS(60,3) Fatal: Cannot find Comm used by ddfossil". This is a fresh Lazarus install. I assume I'm missing a dependency - how can I fix?

EDIT on 7/20: Please disregard question 2 here. I managed to locate the missing comm.pas file in your RMDoor repository. Dropping that into the USURPER\DDPLUS folder lets the program compile.

codefenix-ConChaos commented 4 years ago

I can confirm the DDPlus build fixes the issues. Pressing [enter] now auto-selects the default option when it should.