Relevance Terminology - Githubissues

rickvanveen / sklvq

http://sklvq.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

49 stars 9 forks source link

Relevance Terminology #55

Open rickvanveen opened 3 years ago

rickvanveen commented 3 years ago

Is your feature request related to a problem? Please describe. Inconsistency with literature with omega_hat, eigenvalues and eigenvectors.

Describe the solution you'd like Add eigenvectors, that contain the unit eigenvectors Keep the eigenvalues (are already there) Change omega_hat to the scaled (by the square root of the eigenvalues) eigenvectors, such that omega_hat.T.dot(omega_hat) == lambda.

Describe alternatives you've considered n/a

Additional context n/a

rickvanveen commented 3 years ago

The documentation needs to be updated:

[ ] omega_hat -> eigenvectors
[ ] eigenvectors are stored as a row matrix (as is omega_hat now) and the index is therefore wrong.