rickyah / ini-parser

Read/Write an INI file the easy way!
MIT License
971 stars 241 forks source link

.NET Core/.NET Standard Library 1.6 compatibility #122

Closed wdominik closed 5 years ago

wdominik commented 7 years ago

Are there currently any plans to provide a package for .NET Core/.NET Standard Library 1.6?

Svetomech commented 7 years ago

Is there any particular reason you'd want to use INI file format w/ .NET core?

wdominik commented 7 years ago

I need to communicate with another programm that uses INI files for transfer. Since I start this project from scratch, I'm evaluating the use of the .NET Core framework to be as portable as possible. It is not striclty necessary indeed, but since ini-parser is designed with portability in mind, I thought there might be plans to provide a .NET Standard 1.6 package.

Svetomech commented 7 years ago

Reasonable. @rickyah, any plans on that?

rickyah commented 7 years ago

Been somehow disconnected from .NET platform development although I tried to keep myself up with latest changes in the ecosystem. However I had to read about what .NET standard is, and what it is useful for. I do not have any plans to create a .NET standard package because it seems like something not widely adopted, so I'll wait until all this gets more traction

I've tried to run apiport on ini-parser's assembly and support on mono is really subpar :( although it seem to be .NET Standard 2.0 complaint

Nothing4You commented 7 years ago

please reopen this. even if you don't plan to support this for now so it won't get lost.

DenisDollfus commented 7 years ago

Needed here too.

rickyah commented 7 years ago

I'll reopen this by petition, but if anyone can provide some links about how to create a library compatible with .net core 1.6 I'll be really happy :)

Nothing4You commented 7 years ago

Suggestions that were brought to me were having 2 different csproj files, one targeting .net fx 2.0, one targeting .net standard 1.6. since not all code is compatible with both .net versions a wrapper class should be created with an implementation for each version. then each csproj file should exclude the other versions implementation of that class. there's only a few places where code isn't compatible: https://hosting.rep.pm/ini-parser/AnalysisReport.html (based on the current v3 dev branch)

agc93 commented 7 years ago

@Nothing4You Couldn't this also be done with one csproj file, targeting both frameworks, then use conditional compilation symbols to ignore the incompatible parts?

Nothing4You commented 7 years ago

probably, i haven't messed with conditional csproj files so far.

agc93 commented 7 years ago

@rickyah @Nothing4You I've opened #149 for enabling .NET Standard 1.3 support based on the current development branch (rather than 3.0).

Feedback and questions welcome.

sylveon commented 7 years ago

The library from NuGet works fine in .NET Core 2.0 BTW thanks to backwards binary compatibility.

pulimento commented 5 years ago

netstandard / netcore port in #188 🎊