search

rickypc / selenium-page-object-generator

A nimble and flexible Selenium Page Object Model generator to improve agile testing process velocity.
https://chrome.google.com/webstore/detail/epgmnmcjdhapiojbohkkemlfkegmbebb
GNU Affero General Public License v3.0
121 stars 65 forks source link

Incorrect naming convention #1

Closed naiduv closed 9 years ago

naiduv commented 9 years ago

It names the variables a little incorrectly.. For instance it names them debianaUsernamePassword1 and debibanaUsernamePassword2, but a correct name would be debianaUsername and debianaPassword.. attached image of html and code in c#..

image

For some reason image

rickypc commented 9 years ago

Venkat,

The reason why the tool did not find the label for the input element is because the "for" attribute do not match with the input element "id" attribute. https://www.w3.org/wiki/HTML/Elements/label#HTML_Attributes

If you are able to change the "for" label attribute to match to "id" input attribute, the tool will give you "password" and "userName" variable names (camel case of label text).

I will take this issue as an enhancement to the tool. Thanks, Venkat.

rickypc commented 9 years ago

Version 1.2.2 should return better result without modifying the page source, otherwise please reopen this issue.

naiduv commented 9 years ago

Sounds good!