search

rickypc / selenium-page-object-generator

A nimble and flexible Selenium Page Object Model generator to improve agile testing process velocity.
https://chrome.google.com/webstore/detail/epgmnmcjdhapiojbohkkemlfkegmbebb
GNU Affero General Public License v3.0
121 stars 65 forks source link

bug fix: handle case textContent may not be valid string #20

Closed jeshan closed 6 years ago

jeshan commented 7 years ago

I ran into this issue while working on my own app. Sending in a fix.

rickypc commented 7 years ago

Thank you, @jeshan. Would you please fill in the CLA located here: https://goo.gl/forms/Bax4dq33Q7 . Thanks.

jeshan commented 7 years ago

done.

jeshan commented 7 years ago

hey @rickypc i added 2 commits by accident to this merge request. I didn't realise that I need to work in separate branches for separate pull requests.

these two are bug fixes needed too. You may observe the issues while generating a github project page, e.g https://github.com/rickypc/selenium-page-object-generator

rickypc commented 6 years ago

Released in version 1.3.0. Thanks, @jeshan for your contribution.