search

rickypc / selenium-page-object-generator

A nimble and flexible Selenium Page Object Model generator to improve agile testing process velocity.
https://chrome.google.com/webstore/detail/epgmnmcjdhapiojbohkkemlfkegmbebb
GNU Affero General Public License v3.0
122 stars 66 forks source link

Bad code generated #3

Closed adamf663 closed 9 years ago

adamf663 commented 9 years ago

Tried plugin; it generates some bad code. 1) clickl method out of nowhere followed by invalid java code. /* * Submit the form to target page. * @return the GoogleHomePage class instance. */ public GoogleHomePage submit() { clickI'mFeelingLuckyButton(); return this; } 2) WebDriverWait, ExpectedCondition

If necessary I can post the code, or you can simply go to google.com and run the plugin to generate a java page object model class.

rickypc commented 9 years ago

Good catch, Adam. Should be fixed in version 1.2.5. Please reopen otherwise.

adamf663 commented 9 years ago

Also: it doesn't handle tables properly. It generated a separate element/click/set for every cell. No biggie; I'll hand edit to handle such cases.

It's a great tool and I expect it to be a tremendous time saver.

----- Original Message -----

From: "Richard Huang" notifications@github.com To: "rickypc/selenium-page-object-generator" selenium-page-object-generator@noreply.github.com Cc: "adamf663" adam.github@thefelsons.us Sent: Tuesday, September 22, 2015 9:45:39 PM Subject: Re: [selenium-page-object-generator] Bad code generated (#3)

Closed #3.

Reply to this email directly or view it on GitHub: https://github.com/rickypc/selenium-page-object-generator/issues/3#event-416569055