search

rickypc / selenium-page-object-generator

A nimble and flexible Selenium Page Object Model generator to improve agile testing process velocity.
https://chrome.google.com/webstore/detail/epgmnmcjdhapiojbohkkemlfkegmbebb
GNU Affero General Public License v3.0
121 stars 65 forks source link

Cleanup #8

Open VaccinalBowl opened 8 years ago

VaccinalBowl commented 8 years ago

Hi.

I am using your code but I notice some problem in generator.js. I am not sure if it is a bug or not but if so I have fixed an issue.

In the generator.js file some css selectors from the web will cause an exception. I have added a try catch block to catch that and just print with console.log that an error has occur. This has made your code run on much more web pages than before.

I am not sure if this is intentional but maybe you want to pull it to the master repository.

rickypc commented 6 years ago

Thank you, @VaccinalBowl. Would you please fill in the CLA located here if you haven't done so: https://goo.gl/forms/Bax4dq33Q7. Thanks.

VaccinalBowl commented 6 years ago

Hi Richard

I filled in the form and submit it

On Sat 7. Apr 2018 at 18:38, Richard Huang notifications@github.com wrote:

Thank you, @VaccinalBowl https://github.com/VaccinalBowl. Would you please fill in the CLA located here if you haven't done so: https://goo.gl/forms/Bax4dq33Q7. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rickypc/selenium-page-object-generator/pull/8#issuecomment-379482491, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfkjBhiNBTXwFl7gHBlYvWco-F_qwJdks5tmOtrgaJpZM4I22Xs .