Closed rickysarraf closed 2 years ago
Thanks for this bug report.
For one, I don't have a Windows machine to do routine tests. So thank you very much for reporting this issue from Windows.
The reason it failed is because we were only doing source releases. And do Windows, we still needed to have the .ui files compiled to .py files. This is being done by the Makefile/bash script (which in turn calls pyuic and frieds), which users may not be installed on end-user Windows machine.
Once this is validated in this bug report, we should update the release
steps to also cover for Microsoft Windows platform.
rrs@priyasi:.../apt-offline$ ls apt_offline_gui/
AptOfflineQtAbout.py AptOfflineQtCreateProfile.ui AptOfflineQtFetch.ui AptOfflineQtInstallChangelog.ui AptOfflineQtMain.ui icons/ UiDataStructs.py
AptOfflineQtAbout.ui AptOfflineQtFetchOptions.py AptOfflineQtInstallBugList.py AptOfflineQtInstall.py AptOfflineQtSaveZip.py __init__.py
AptOfflineQtCommon.py AptOfflineQtFetchOptions.ui AptOfflineQtInstallBugList.ui AptOfflineQtInstall.ui AptOfflineQtSaveZip.ui QtProgressBar.py
AptOfflineQtCreateProfile.py AptOfflineQtFetch.py AptOfflineQtInstallChangelog.py AptOfflineQtMain.py genui.sh* resources.qrc
14:02 ♒ ॐ ♅ ♄ ⛢ ☺ 😄
rrs@priyasi:.../apt-offline$ make
cd apt_offline_gui ; ./genui.sh || exit 1
Compiling Ui files
Compiling file AptOfflineQtAbout.ui into Ui_AptOfflineQtAbout.py
Compiling file AptOfflineQtCreateProfile.ui into Ui_AptOfflineQtCreateProfile.py
Compiling file AptOfflineQtFetch.ui into Ui_AptOfflineQtFetch.py
Compiling file AptOfflineQtFetchOptions.ui into Ui_AptOfflineQtFetchOptions.py
Compiling file AptOfflineQtInstall.ui into Ui_AptOfflineQtInstall.py
Compiling file AptOfflineQtInstallBugList.ui into Ui_AptOfflineQtInstallBugList.py
Compiling file AptOfflineQtInstallChangelog.ui into Ui_AptOfflineQtInstallChangelog.py
Compiling file AptOfflineQtMain.ui into Ui_AptOfflineQtMain.py
Compiling file AptOfflineQtSaveZip.ui into Ui_AptOfflineQtSaveZip.py
Compiling Resources files
Done
python3 setup.py build
/var/tmp/windows/apt-offline/setup.py:10: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
import distutils.core
running build
running build_py
creating build
creating build/lib
creating build/lib/apt_offline_core
copying apt_offline_core/__init__.py -> build/lib/apt_offline_core
copying apt_offline_core/AptOfflineCoreLib.py -> build/lib/apt_offline_core
copying apt_offline_core/AptOfflineDebianBtsLib.py -> build/lib/apt_offline_core
copying apt_offline_core/AptOfflineLib.py -> build/lib/apt_offline_core
copying apt_offline_core/AptOfflineMagicLib.py -> build/lib/apt_offline_core
creating build/lib/apt_offline_gui
copying apt_offline_gui/__init__.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtAbout.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtCommon.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtCreateProfile.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtFetch.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtFetchOptions.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtInstall.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtInstallBugList.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtInstallChangelog.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtMain.py -> build/lib/apt_offline_gui
copying apt_offline_gui/AptOfflineQtSaveZip.py -> build/lib/apt_offline_gui
copying apt_offline_gui/QtProgressBar.py -> build/lib/apt_offline_gui
copying apt_offline_gui/resources_rc.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtAbout.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtCreateProfile.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtFetch.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtFetchOptions.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtInstall.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtInstallBugList.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtInstallChangelog.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtMain.py -> build/lib/apt_offline_gui
copying apt_offline_gui/Ui_AptOfflineQtSaveZip.py -> build/lib/apt_offline_gui
copying apt_offline_gui/UiDataStructs.py -> build/lib/apt_offline_gui
running build_scripts
creating build/scripts-3.10
copying and adjusting apt-offline -> build/scripts-3.10
copying and adjusting apt-offline-gui -> build/scripts-3.10
copying apt-offline-gui-pkexec -> build/scripts-3.10
changing mode of build/scripts-3.10/apt-offline from 644 to 755
changing mode of build/scripts-3.10/apt-offline-gui from 644 to 755
man2html apt-offline.8 > apt-offline.html
14:02 ♒ ॐ ♅ ♄ ⛢ ☺ 😄
rrs@priyasi:.../apt-offline$ ls apt_offline_gui/
AptOfflineQtAbout.py AptOfflineQtFetchOptions.ui AptOfflineQtInstallChangelog.ui AptOfflineQtSaveZip.ui resources_rc.py Ui_AptOfflineQtInstallChangelog.py
AptOfflineQtAbout.ui AptOfflineQtFetch.py AptOfflineQtInstall.py genui.sh* Ui_AptOfflineQtAbout.py Ui_AptOfflineQtInstall.py
AptOfflineQtCommon.py AptOfflineQtFetch.ui AptOfflineQtInstall.ui icons/ Ui_AptOfflineQtCreateProfile.py Ui_AptOfflineQtMain.py
AptOfflineQtCreateProfile.py AptOfflineQtInstallBugList.py AptOfflineQtMain.py __init__.py Ui_AptOfflineQtFetchOptions.py Ui_AptOfflineQtSaveZip.py
AptOfflineQtCreateProfile.ui AptOfflineQtInstallBugList.ui AptOfflineQtMain.ui QtProgressBar.py Ui_AptOfflineQtFetch.py UiDataStructs.py
AptOfflineQtFetchOptions.py AptOfflineQtInstallChangelog.py AptOfflineQtSaveZip.py resources.qrc Ui_AptOfflineQtInstallBugList.py
Could the bug reported please test the attached .zip archive in this comment ?
rrs@priyasi:.../windows$ zip -r apt-offline-windows.zip apt-offline
adding: apt-offline/ (stored 0%)
adding: apt-offline/.github/ (stored 0%)
adding: apt-offline/.github/FUNDING.yml (stored 0%)
adding: apt-offline/.github/workflows/ (stored 0%)
adding: apt-offline/.github/workflows/main.yml (deflated 52%)
adding: apt-offline/.gitignore (deflated 23%)
adding: apt-offline/.mailmap (deflated 64%)
adding: apt-offline/.project (deflated 47%)
adding: apt-offline/.pydevproject (deflated 49%)
adding: apt-offline/.travis.yml (deflated 47%)
adding: apt-offline/.vscode/ (stored 0%)
adding: apt-offline/.vscode/launch.json (deflated 69%)
adding: apt-offline/INSTALL (deflated 43%)
adding: apt-offline/LICENSE (deflated 66%)
adding: apt-offline/Makefile (deflated 46%)
adding: apt-offline/README.md (deflated 43%)
adding: apt-offline/THANKS (deflated 27%)
adding: apt-offline/_config.yml (deflated 7%)
adding: apt-offline/apt-offline (deflated 63%)
adding: apt-offline/apt-offline-gui (deflated 60%)
adding: apt-offline/apt-offline-gui-pkexec (deflated 26%)
adding: apt-offline/apt-offline-gui.desktop (deflated 23%)
adding: apt-offline/apt-offline.8 (deflated 65%)
adding: apt-offline/apt-offline.html (deflated 68%)
adding: apt-offline/apt_offline_core/ (stored 0%)
adding: apt-offline/apt_offline_core/AptOfflineCoreLib.py (deflated 80%)
adding: apt-offline/apt_offline_core/AptOfflineDebianBtsLib.py (deflated 69%)
adding: apt-offline/apt_offline_core/AptOfflineLib.py (deflated 76%)
adding: apt-offline/apt_offline_core/AptOfflineMagicLib.py (deflated 72%)
adding: apt-offline/apt_offline_core/__init__.py (stored 0%)
adding: apt-offline/apt_offline_core/__pycache__/ (stored 0%)
adding: apt-offline/apt_offline_core/__pycache__/__init__.cpython-310.pyc (deflated 27%)
adding: apt-offline/apt_offline_core/__pycache__/AptOfflineCoreLib.cpython-310.pyc (deflated 54%)
adding: apt-offline/apt_offline_core/__pycache__/AptOfflineLib.cpython-310.pyc (deflated 54%)
adding: apt-offline/apt_offline_core/__pycache__/AptOfflineMagicLib.cpython-310.pyc (deflated 58%)
adding: apt-offline/apt_offline_gui/ (stored 0%)
adding: apt-offline/apt_offline_gui/AptOfflineQtAbout.py (deflated 57%)
adding: apt-offline/apt_offline_gui/AptOfflineQtAbout.ui (deflated 81%)
adding: apt-offline/apt_offline_gui/AptOfflineQtCommon.py (deflated 58%)
adding: apt-offline/apt_offline_gui/AptOfflineQtCreateProfile.py (deflated 78%)
adding: apt-offline/apt_offline_gui/AptOfflineQtCreateProfile.ui (deflated 87%)
adding: apt-offline/apt_offline_gui/AptOfflineQtFetch.py (deflated 77%)
adding: apt-offline/apt_offline_gui/AptOfflineQtFetch.ui (deflated 81%)
adding: apt-offline/apt_offline_gui/AptOfflineQtFetchOptions.py (deflated 73%)
adding: apt-offline/apt_offline_gui/AptOfflineQtFetchOptions.ui (deflated 87%)
adding: apt-offline/apt_offline_gui/AptOfflineQtInstall.py (deflated 75%)
adding: apt-offline/apt_offline_gui/AptOfflineQtInstall.ui (deflated 83%)
adding: apt-offline/apt_offline_gui/AptOfflineQtInstallBugList.py (deflated 77%)
adding: apt-offline/apt_offline_gui/AptOfflineQtInstallBugList.ui (deflated 77%)
adding: apt-offline/apt_offline_gui/AptOfflineQtInstallChangelog.py (deflated 68%)
adding: apt-offline/apt_offline_gui/AptOfflineQtInstallChangelog.ui (deflated 70%)
adding: apt-offline/apt_offline_gui/AptOfflineQtMain.py (deflated 78%)
adding: apt-offline/apt_offline_gui/AptOfflineQtMain.ui (deflated 84%)
adding: apt-offline/apt_offline_gui/AptOfflineQtSaveZip.py (deflated 62%)
adding: apt-offline/apt_offline_gui/AptOfflineQtSaveZip.ui (deflated 74%)
adding: apt-offline/apt_offline_gui/QtProgressBar.py (deflated 71%)
adding: apt-offline/apt_offline_gui/UiDataStructs.py (deflated 74%)
adding: apt-offline/apt_offline_gui/__init__.py (stored 0%)
adding: apt-offline/apt_offline_gui/genui.sh (deflated 42%)
adding: apt-offline/apt_offline_gui/icons/ (stored 0%)
adding: apt-offline/apt_offline_gui/icons/application-exit.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/configure.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/contact-new.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/dialog-cancel.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/dialog-ok-apply.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/document-save.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/go-down.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/help-about.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/help-contents.png (stored 0%)
adding: apt-offline/apt_offline_gui/icons/install.png (stored 0%)
adding: apt-offline/apt_offline_gui/resources.qrc (deflated 64%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtAbout.py (deflated 76%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtCreateProfile.py (deflated 84%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtFetch.py (deflated 77%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtFetchOptions.py (deflated 86%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtInstall.py (deflated 79%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtInstallBugList.py (deflated 75%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtInstallChangelog.py (deflated 70%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtMain.py (deflated 80%)
adding: apt-offline/apt_offline_gui/Ui_AptOfflineQtSaveZip.py (deflated 68%)
adding: apt-offline/apt_offline_gui/resources_rc.py (deflated 65%)
adding: apt-offline/apt_offline_gui/__pycache__/ (stored 0%)
adding: apt-offline/apt_offline_gui/__pycache__/__init__.cpython-310.pyc (deflated 27%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtMain.cpython-310.pyc (deflated 58%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtMain.cpython-310.pyc (deflated 54%)
adding: apt-offline/apt_offline_gui/__pycache__/resources_rc.cpython-310.pyc (deflated 9%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtCreateProfile.cpython-310.pyc (deflated 54%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtCreateProfile.cpython-310.pyc (deflated 58%)
adding: apt-offline/apt_offline_gui/__pycache__/UiDataStructs.cpython-310.pyc (deflated 55%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtCommon.cpython-310.pyc (deflated 38%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtFetch.cpython-310.pyc (deflated 54%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtFetch.cpython-310.pyc (deflated 50%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtFetchOptions.cpython-310.pyc (deflated 49%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtFetchOptions.cpython-310.pyc (deflated 59%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtInstall.cpython-310.pyc (deflated 56%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtInstall.cpython-310.pyc (deflated 51%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtInstallBugList.cpython-310.pyc (deflated 46%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtInstallBugList.cpython-310.pyc (deflated 47%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtInstallChangelog.cpython-310.pyc (deflated 42%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtInstallChangelog.cpython-310.pyc (deflated 44%)
adding: apt-offline/apt_offline_gui/__pycache__/AptOfflineQtAbout.cpython-310.pyc (deflated 42%)
adding: apt-offline/apt_offline_gui/__pycache__/Ui_AptOfflineQtAbout.cpython-310.pyc (deflated 51%)
adding: apt-offline/bash_completion/ (stored 0%)
adding: apt-offline/bash_completion/apt-offline (deflated 80%)
adding: apt-offline/org.debian.apt.aptoffline.policy (deflated 55%)
adding: apt-offline/release_setps (deflated 41%)
adding: apt-offline/requirements.txt (deflated 37%)
adding: apt-offline/setup.py (deflated 67%)
adding: apt-offline/tests/ (stored 0%)
adding: apt-offline/tests/apt-offline-testcase.bat (deflated 78%)
adding: apt-offline/tests/apt-offline-tests-github.sh (deflated 83%)
adding: apt-offline/tests/apt-offline-tests.sh (deflated 85%)
adding: apt-offline/tests/set-update.uris (deflated 93%)
Could the bug reported please test the attached .zip archive in this comment ?
Hi. It seem it works. At least build and install steps finished without errors.
Could the bug reported please test the attached .zip archive in this comment ?
Hi. It seem it works. At least build and install steps finished without errors.
Thank you. But could you please confirm that the UI renders proper on Windows ? And that all apt-offline
functionality also works in the UI on Windows ?
Once you confirm, then I'll update my release steps documentation to cover for Windows henceforth.
A windows user reports