rickysarraf / foxreplace

Automatically exported from code.google.com/p/foxreplace
0 stars 0 forks source link

"Susbstitution group editor" OK Button is Deceptive #125

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to "Susbstitution group editor" window
2. Click on "Substitutions" tab
3. Complete the "Replace" & "With" fields
4. Click OK button (not Add button)

What is the expected output? What do you see instead?

I expect the "OK" button to exit me from this window *after* automatically 
applying the changes (usually in Windows there is an "Apply" button but here 
there is an "Add" button). Either that or don't let the "OK" button do anything 
once the fields have been filled - only allow Cancel or Add buttons.

Instead it behaves as if I had clicked on the "Cancel" button.

What version of the product are you using? On what operating system?

FoxReplace 0.15.0, Windows 7

Please provide any additional information below.

It often used to happen that I used to think I had programmed a replacement in 
FoxReplace and wondered why it was ignored and had disappeared. It took a long 
time to realise what I was accidentally doing wrong: Sometimes I was clicking 
on "Add", sometimes on "OK". It drove me nuts.

Original issue reported on code.google.com by sqgl2...@gmail.com on 24 Sep 2013 at 12:49

GoogleCodeExporter commented 9 years ago
Good point. It should at least show a warning if the fields are filled but the 
substitution hasn't been added.

Original comment by marc.r...@gmail.com on 24 Sep 2013 at 3:45

GoogleCodeExporter commented 9 years ago
Another bad scenario is when the substitution definition exists (therefore the 
fields are already filled) and I try to edit the fields. In this case there is 
no "Add" (nor "Apply"), just an "OK" button *in*addition*to* the "OK" button at 
the bottom of the same window. If you click on the lower "OK" button your edits 
are lost.

Original comment by sqgl2...@gmail.com on 24 Sep 2013 at 5:18

GoogleCodeExporter commented 9 years ago

Original comment by marc.r...@gmail.com on 23 Apr 2014 at 6:23

GoogleCodeExporter commented 9 years ago
Fixed in r220.

Original comment by marc.r...@gmail.com on 23 Apr 2014 at 9:47