search

rickysarraf / laptop-mode-tools

Power Savings tool for Linux
https://www.researchut.com/tags/laptop-mode-tools/
GNU General Public License v2.0
550 stars 47 forks source link

Buggy /usr/share/laptop-mode-tools/modules/ethernet? #171

Open kamil4 opened 2 years ago

kamil4 commented 2 years ago

I believe I spotted a bug in version 1.74 in /usr/share/laptop-mode-tools/modules/ethernet.

https://github.com/rickysarraf/laptop-mode-tools/blob/9839bd2a1d761f8fe476fa91aee2cc7909d4aa59/usr/share/laptop-mode-tools/modules/ethernet#L36

https://github.com/rickysarraf/laptop-mode-tools/blob/9839bd2a1d761f8fe476fa91aee2cc7909d4aa59/usr/share/laptop-mode-tools/modules/ethernet#L64

Lines 36 and 64 reference DEVICE, which should not be available outside the loop that only starts in line 104?

https://github.com/rickysarraf/laptop-mode-tools/blob/9839bd2a1d761f8fe476fa91aee2cc7909d4aa59/usr/share/laptop-mode-tools/modules/ethernet#L104

Thank you!