rickysarraf / laptop-mode-tools

Power Savings tool for Linux
https://www.researchut.com/tags/laptop-mode-tools/
GNU General Public License v2.0
550 stars 47 forks source link

lm-profiler not working on linux kernel 5.14 and higher #202

Closed chadek closed 1 year ago

chadek commented 1 year ago

Describe the bug lm-profiler is not working on debian kernel 6.1.0-0.deb11.7-amd64 because of /proc/sys/vm/block_dump

To Reproduce Steps to reproduce the behavior:

  1. install laptop-mode-tools on a machine with a kernel 5.14 or higher
  2. run lm-profiler
  3. The following error show up /usr/sbin/lm-profiler: 82: cannot create /proc/sys/vm/block_dump: Directory nonexistent

Expected behavior lm-profiler should start profiling

Important Information:

Additional context As describe here, block_dump was removed from kernel, they suggest to use tracepoints instead. Maybe looking at /sys/kernel/tracing/README might help to find a replacement to the old block_dump interface

rickysarraf commented 1 year ago

Thank you for the report. And my apologies for the delayed response 🙏🏽

I will check on the status and possible alternates.

rickysarraf commented 1 year ago

@chadek Does this look good to you ?

chadek commented 1 year ago

Just tried it out and it seams to work. I had no clue on how this tool work normally as it is the first time I use it. Profiling starts and seams to do the job. It would just be better if this tool as less dependency (btrace come with a lot a things) but this is an other topics.

Thanks for the fix!

rickysarraf commented 1 year ago

Just tried it out and it seams to work. I had no clue on how this tool work normally as it is the first time I use it. Profiling starts and seams to do the job. It would just be better if this tool as less dependency (btrace come with a lot a things) but this is an other topics.

Thanks for the fix!

Thanks for the feedback. The name being duplicate is a possibility, which is why that is pushed to the packagers, who could add a dependency/recommendation to this package.