search

rickysarraf / laptop-mode-tools

Power Savings tool for Linux
https://www.researchut.com/tags/laptop-mode-tools/
GNU General Public License v2.0
553 stars 47 forks source link

message appearing after login #208

Closed thoughtpatterns closed 8 months ago

thoughtpatterns commented 8 months ago

Describe the bug Booting on runit system places message on login prompt. This is purely cosmetic and does not impact login or functionality.

To Reproduce Steps to reproduce the behavior:

  1. Install "laptop-mode" on Void Linux
  2. Boot the system (I am using GRUB with LUKS1 encryption) with laptop plugged into AC
  3. A message will appear by username prompt: "enabled, not active [unchanged]"

Expected behavior This message appears before the prompt, rather than during.

Screenshots

p50prompt

Important Information:

Additional context The prompt is coming from here, I believe (as pointed out to me by someone else!) The prompt isn't erroneous, I'm just wondering how to change the laptop_mode service to not trigger simultaneously with login (which I believe it is, because I have my tty set to clear before login), if at all possible

rickysarraf commented 8 months ago

Hello @moeishome

I'm just wondering how to change the laptop_mode service to not trigger simultaneously with login

Laptop Mode Tools (LMT) is invoked via multiple means. The important bit is that whether the service is enabled in /etc/laptop-mode/laptop-mode.conf

It is invoked via:

The message that you are seeing is possibly by your init manager and/or udev. I can't tell for sure until this is investigated. What I can say for sure that on my system (Debian + systemd) those messages do not show up. But then, that is because we tell systemd to use the journal for LMT's stdout and stderr.

rrs@priyasi:~$ systemctl cat laptop-mode
# /usr/lib/systemd/system/laptop-mode.service
[Unit]
Description=Laptop Mode Tools
Documentation=man:laptop_mode(8) man:laptop-mode.conf(8)
Documentation=http://github.com/rickysarraf/laptop-mode-tools

[Service]
Type=oneshot
RemainAfterExit=yes
ExecStartPre=/bin/rm -f /var/run/laptop-mode-tools/enabled
ExecStartPre=/bin/rm -f /var/run/laptop-mode-tools/state
ExecStart=/usr/sbin/laptop_mode init force
ExecStop=/usr/sbin/laptop_mode init stop
ExecStopPost=/bin/rm -f /var/run/laptop-mode-tools/enabled
ExecStopPost=/bin/rm -f /var/run/laptop-mode-tools/state
ExecReload=/usr/sbin/laptop_mode auto
StandardOutput=journal
StandardError=journal
TasksMax=infinity

[Install]
WantedBy=multi-user.target

Perhaps a similar setting may be needed in your setup/init

thoughtpatterns commented 8 months ago

Interesting! Thanks so much for your response. I'll take a look and find how to disable something like that in runit, and I appreciate the example as well. As this is something on my end I will close this and update the issue with how I fixed it if/when I figure it out. Thank you for making laptop mode!!!

rickysarraf commented 7 months ago

Oh!! I didn't know that Github is losing messages as well. I have an email notification for a comment from you @moeishome but the same doesn't reflect on this issue here.

@moeishome About the QUIET feature flag, nobody ever asked for. But it is easy to do. I'd like you to contribute via a PR here. Just look into the log() function and extend it for quiet mode as well.

thoughtpatterns commented 7 months ago

sure! sorry, its been a minute. when i get a chance i will definitely look into this; in the meantime ive just piped the output of the runit "run" file into /dev/null and i figure theres a more elegant way to manage that. bit hectic right now but will do this! thanks for the invitation, much appreciated.