search

rickytan / RTImageAssets

A Xcode plugin to automatically generate 2x, 1x image from 3x image for you, or upscale to 3x from 2x
MIT License
2.46k stars 334 forks source link

Doesn't preserve color space in my case #67

Open antongaenko opened 8 years ago

antongaenko commented 8 years ago

Hi! Nice plugin. I notice problems with generated images when running on device. 3x images look as they should, but 2x have different colors a little. I think in my case it's because 3x images have sRGB IEC61966-2.1 color space, but generated images have Generic RGB Profile (which I think is by default in Plugin?). When I provide both in sRGB IEC61966-2.1 all is OK. My iMac has been set sRGB IEC61966-2.1 in Settings/Monitor. Where could issue be?

antongaenko commented 8 years ago

Just reinstall with Package Manager to be sure running last version and it has this issue

rickytan commented 8 years ago

Sorry, I don't know quite a lot about color space stuffs, in fact, I tried to preserve the origin image's color space, but sometimes fails: https://github.com/rickytan/RTImageAssets/blob/master/RTImageAssets/IAImageSet.m#L46

Can you help me with this?

antongaenko commented 8 years ago

I'm not familiar with color space management too :smile: Above code seems well. No thoughts where issue could live...