search

rickyvetter / reductive

Redux in Reason
MIT License
409 stars 40 forks source link

Upgrade JSX version to v3 for upgrades to Bucklescript v8 #63

Closed rolandpeelen closed 4 years ago

rolandpeelen commented 4 years ago

This should fix https://github.com/reasonml-community/reductive/issues/60

It seems the only thing needed was a bump in the version spec and a rewrite on one of the examples. To make the example slightly clearer / more readable I moved a thing or two into a module here and there. More like one would have in an actual project. The only thing I removed was the Thunks as I'm unfamiliar with the typing there. It seems that it also adds complexity to the example where it shouldn't.

ambientlight commented 4 years ago

@rolandpeelen: tried building your branch, on bs-platform 8.2.0 complained with jsx is not supported in explicit jsx3 annotation:

[@bs.config {jsx: 3}];

in reductiveContext.re and subscription.re.

Removing those explicit jsx3 annotation fixed the build for me.

ambientlight commented 4 years ago

@rickyvetter: Thanks!